[Development] How to handle duplicated zlib in different repos?
thiago.macieira at intel.com
Thu May 24 14:40:22 CEST 2012
On quinta-feira, 24 de maio de 2012 12.03.28, Anttila Janne wrote:
> So what would be the correct approach?
> 1. Duplicate zlib to needed repos and try to keep different instances in
> sync (Like done currently)
> 2. Use exported zlib symbols from QtBase and
> include needed zlib header from QtBase to QtBase repo.
> 3. Use zlib
> functions from QtBase as extern, like suggested by Friedemann in comments
> to my change? If that is doable...
> 4. Something else, for example move zlib
> to a new static library inside QtBase repo or even move it to a separate
> In short term I would like to go with approach 1 or 2. Something from
> approach 4 is probably better in long term, but is it needed now? Has there
> been similar issues with other 3rparty modules in Qt5, and what is the way
> to go?
>  https://codereview.qt-project.org/23497
To do #2, we need to properly namespace the zlib symbols so that we don't
clash with a user-provided zlib.
I don't understand #3 and the comment from Friedemann in the change doesn't
I'd say also say that #1 is the simplest, short-term solution, but #4 is the
goal, after we have a decent buildsystem that can pull it off.
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 190 bytes
Desc: This is a digitally signed message part.
Url : http://lists.qt-project.org/pipermail/development/attachments/20120524/5407ffc5/attachment.bin
More information about the Development