[Development] Proposal - QtSerialPort graduation from the Playground

Knoll Lars Lars.Knoll at digia.com
Fri Jan 25 22:05:14 CET 2013


Hi Lazlo,

sorry for the late answer.

I went through the module now, and it looks like a good and solid piece of work. Thanks to everybody who contributed :)

>From an API perspective it looks pretty good. I'm not an expert on serial ports, but from what I recall from the time I dealt a little with them (must be 10 years ago or so…) it looks pretty complete as well. S o with the changes proposed on the mailing list I believe the API is good to go :)

Docs are also looking good IMO, so I'm happy to graduate it to an add-on for 5.1.

There are a few remaining things I'd like to see happen before that though:

* Could you please fix the copyright headers to out standard form (simply check a header from qtbase)?
* Could you give the module the same structure as the other Qt modules, esp. with regards to where the source for the docs live? Please check http://qt-project.org/wiki/Creating-a-new-module-or-tool-for-Qt and make sure the module follows the guidelines.
* I'm fine calling the module just QtSerialPort instead of QtAddonSerialPort to simplify naming. I doubt we'll get conflicts in the future because of that.
* The double namespace is a requirement we have removed, a simple "namespace QtSerialPort" is enough.

And a question: There's no auto tests. I know that testing serial ports can't really be done in an automated fashion, but is there anything we can do to cover the module?

Cheers,
Lars


On Jan 10, 2013, at 8:47 PM, Laszlo Papp <lpapp at kde.org<mailto:lpapp at kde.org>> wrote:

API headers:

http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialport.h
http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialportinfo.h

Docs:

http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialport.cpp
http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialportinfo.cpp

Examples:

http://qt.gitorious.org/qtplayground/qtserialport/trees/master/examples

On Wed, Jan 9, 2013 at 10:37 PM, Thiago Macieira <thiago.macieira at intel.com<mailto:thiago.macieira at intel.com>> wrote:
On quarta-feira, 9 de janeiro de 2013 21.18.40<tel:2013%2021.18.40>, Laszlo Papp wrote:
> Another try: can we reiterate this question for 5.1?

Can you post the API headers and a link to the docs and examples, so we can do
an API review?
--
Thiago Macieira - thiago.macieira (AT) intel.com<http://intel.com/>
  Software Architect - Intel Open Source Technology Center

_______________________________________________
Development mailing list
Development at qt-project.org<mailto:Development at qt-project.org>
http://lists.qt-project.org/mailman/listinfo/development


_______________________________________________
Development mailing list
Development at qt-project.org<mailto:Development at qt-project.org>
http://lists.qt-project.org/mailman/listinfo/development

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.qt-project.org/pipermail/development/attachments/20130125/111ace16/attachment.html 


More information about the Development mailing list