<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)" class="elementToProof">
This case is very complicated. In actual we often expect to get an app_compile_version with the smallest version number. In the above case, it should be 6.3, but the existing code cannot do it. If we have a better way then we can rewrite it, but the current
implementation should be removed anyway, I approve this patch.<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)" class="elementToProof">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)" class="elementToProof">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>发件人:</b> Development <development-bounces@qt-project.org> 代表 Thiago Macieira <thiago.macieira@intel.com><br>
<b>发送时间:</b> 2022年6月9日 19:47<br>
<b>收件人:</b> development@qt-project.org <development@qt-project.org><br>
<b>主题:</b> Re: [Development] Asking for a FF exception for ICU based QStringConverter</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText elementToProof">On Thursday, 9 June 2022 12:36:25 PDT Alexander Akulich wrote:<br>
> On Thu, Jun 9, 2022 at 10:14 PM Thiago Macieira<br>
> <br>
> <thiago.macieira@intel.com> wrote:<br>
> > Doesn't work for libraries.<br>
> <br>
> Can you explain please?<br>
<br>
Libraries don't call QCoreApplication's constructor.<br>
<br>
The application may have been recompiled and thus will inform QCoreApplication <br>
it was compiled against 6.4, but the library in question (a KF6 one) may have <br>
still been compiled against 6.3.<br>
<br>
> I see this correspond to 5.0.0 until<br>
> QCoreApplication constructor called but I thought it would be 'better<br>
> than a leak'.<br>
> QCoreApplicationPrivate::app_compile_version is a part of QtCore, so<br>
> even if it won't work *across* the libraries, it is still available<br>
> for QStringConverter because it is a part of the same library.<br>
<br>
Wrong tool for the job, as explained above. Removing in:<br>
<a href="https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodereview.qt-project.org%2Fc%2Fqt%2Fqtbase%2F%2B%2F415327&data=05%7C01%7C%7C5af22458930f41226e9a08da4a5123a4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637904009592072578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UgJ2X9hDA5QAYd9EyX8kERS4TQFj6vTZaiOa%2BfQ2AVo%3D&reserved=0" data-auth="NotApplicable">https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodereview.qt-project.org%2Fc%2Fqt%2Fqtbase%2F%2B%2F415327&data=05%7C01%7C%7C5af22458930f41226e9a08da4a5123a4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637904009592072578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UgJ2X9hDA5QAYd9EyX8kERS4TQFj6vTZaiOa%2BfQ2AVo%3D&reserved=0</a><br>
<br>
In any case, I'll not make a runtime decision based on version. It's much <br>
easier to make a static decision based on which function you called.<br>
<br>
-- <br>
Thiago Macieira - thiago.macieira (AT) intel.com<br>
Cloud Software Architect - Intel DCAI Cloud Engineering<br>
<br>
<br>
<br>
_______________________________________________<br>
Development mailing list<br>
Development@qt-project.org<br>
<a href="https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.qt-project.org%2Flistinfo%2Fdevelopment&data=05%7C01%7C%7C5af22458930f41226e9a08da4a5123a4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637904009592072578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NOo%2BrXSDc%2BMs6xScq9tiF6T2ocJRxeta7l6ecw3Y5CY%3D&reserved=0" data-auth="NotApplicable">https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.qt-project.org%2Flistinfo%2Fdevelopment&data=05%7C01%7C%7C5af22458930f41226e9a08da4a5123a4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637904009592072578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NOo%2BrXSDc%2BMs6xScq9tiF6T2ocJRxeta7l6ecw3Y5CY%3D&reserved=0</a><br>
</div>
</span></font></div>
</body>
</html>