[Development] V8's location

[Stephen Kelly]

On Monday, December 12, 2011 10:30:31 you wrote:
> Stephen Kelly said:
> > On Wednesday, November 09, 2011 13:54:37 Thiago Macieira wrote:
> > > On Friday, 28 de October de 2011 12:38:38 lars.knoll at nokia.com wrote:
> > > > We've been moving this lib quite a bit already. If we move it
> > > > again, I'd prefer it would end up at it's final location. The
> > > > move was done before we had the decision to keep QtCore
> > > > independent of V8 and to separate the QJS* classes and the QML
> > > > engine into it's own module.
> > > > 
> > > > With the above decision it might make sense to move V8, the QJS*
> > > > classes and the QML engine all into the same shared library.
> > > > 
> > > > Kent & Aaron, any thoughts?
> > > 
> > > Since they don't seem to have an opinion, can we please move it to
> > > top-level inside qt5.git?
> > > 
> > > I've just caught a bad commit in my tree that updates the commit
> > > link to v8 and I'm trying to fix it with an interactive rebase.
> > 
> > Bump. This is a recurring problem with newcomers trying to build qtbase.
> > They don't know to do the git submodule magic or use -no-v8, so the
> > build fails.
> I think this can be easily mitigated by having qmake check if the
> sources exist, rather than simply assuming that they do.
> e.g. http://codereview.qt-project.org/10934 .

This apparently didn't work. 

At least, I've just had someone else fail to build Qt because 

./configure -nomake examples -nomake demos -nomake tests  -opensource -
confirm-license

failed to create a top-level Makefile. People don't read error messages that 
don't terminate the script and that still leave this message at the end:

Qt is now configured for building. Just run 'make'.
Once everything is built, you must run 'make install'.
Qt will be installed into /usr/local/Qt-5.0.0

If v8 is to remain a submodule of qtbase (I still don't see why), and you want 
to make ./configure report an error, you'll have to terminate the script when 
you encounter the error and make sure not to print a message saying 'Just run 
make'.

Especially because the current error message is still output when -no-v8 *is* 
used.

https://bugreports.qt.nokia.com/browse/QTBUG-23206

So the person seeing the error message has to know whether they can ignore it 
or not. Not useful. Rather than fix the script, it's probably easier to just 
remove the submodule and fix all the problems associated with it at once.

Thanks,

-- 
Stephen Kelly <stephen.kelly at kdab.com> | Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20111220/9d651200/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20111220/9d651200/attachment.sig>