[Development] QHttp removal
lars.knoll at nokia.com
lars.knoll at nokia.com
Mon Dec 26 11:08:05 CET 2011
On 12/23/11 3:39 PM, "ext Olivier Goffart" <olivier at woboq.com> wrote:
>On Friday 23 December 2011 09:42:47 Jonas M. Gastal wrote:
>> Hey all,
>>
>> I have just sent to gerrit a patch which removes QHttp from Qt:
>> http://codereview.qt-project.org/#change,11741
>>
>> However I have not removed QHttpHeader and friends, so they're still
>>public
>> and in the QHttp header, I'm wondering if it wouldn't be better to make
>>that
>> stuff private. That API was used in conjunction with QHttp, QNAM doesn't
>> require it(in its public API).
>>
>> We could also consider removing the QHttpHeader* classes entirely but
>>that
>> would entail rewriting all uses of it, there currently are a several.
>>
>> What does everyone think about that?
>
>I'd say, move that class in qhttpheader_p.h
Yes, let's make it private (or get rid of it if possible). For those that
need/use QHttpHeader (and/or QHttp), we can provide the code as a small
static library that you can include in your code base.
Cheers,
Lars
More information about the Development
mailing list