[Development] QT_DEPRECATED_SINCE and QT_DISABLE_DEPRECATED_BEFORE

[bradley.hughes at nokia.com]

On 02 Nov, 2011, at 01:29 , ext Rohan McGovern wrote:

> Thiago Macieira said:
>> On Tuesday, 1 de November de 2011 10:55:49 Frans Klaver wrote:
>>> On Tue, Nov 1, 2011 at 10:43 AM, Thiago Macieira <thiago at kde.org> wrote:
>>>> One more thing: QT_DEPRECATED expands to empty during the Qt build.
>>>> 
>>>> Should we enable QT_DEPRECATED_WARNINGS?
>>> 
>>> FWIW, my personal experience is that build warnings are noticed before
>>> documentation changes. I always feel a deprecation warning during the
>>> build is more likely to push people to move to the new API than just
>>> changing the documentation -- a lot of people like warning-free
>>> builds.
>>> 
>>> So I'd say that would be a yes.
>> 
>> I'd also like to work on enabling -Werror, but usually deprecation warnings 
>> cannot be avoided, so I'll add also a Wno-error-deprecated.
>> 
> 
> I also noticed that Brad recently added the ability to pass through
> options like -Werror into configure [ http://codereview.qt-project.org/7487 ].
> I intend for us to attempt using that in CI as soon as we have newer gcc
> available (>= 4.6), which will be soon.  Any opinions on exactly
> the appropriate -W* options would be appreciated :)

I would love to see us fix all the -Woverloaded-virtual warnings… there are tons of them :(

--
Bradley T. Hughes
bradley.hughes at nokia.com