[Development] API review for a new QDnsResolver class

Thiago Macieira thiago.macieira at intel.com
Tue Nov 8 22:57:03 CET 2011


On Tuesday, 8 de November de 2011 19:40:13 Jeremy Lainé wrote:
> - the QNAM-style API seems to be OK

Correct, but all functions in QDnsResolver are static.

That means they could go into QDnsReply and we could rename the class simply 
QDns. It worked for Qt 3...

> - I have implemented QDnsReply::abort() to cancel a lookup request

Good.

> - Robin mentioned adding a static QDnsResolver::instance() method, does
> anyone else have an opinion on this?

No need if all functions are static.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20111108/fdf6c9dd/attachment.sig>


More information about the Development mailing list