[Development] Maintainer "TrustMes"

[João Abecasis]

On 2. apr. 2012, at 15.22, ext Thiago Macieira wrote:
> One of the duties of a maintainer is to ensure that every contribution to the 
> code he/she maintains is being reviewed. That is, if no one else approves or 
> rejects, the maintainer has the duty to make that happen. I've done this in 
> the past and approved based on +1 given by other people, or by reviewing stuff 
> myself.
> 
> What are we supposed to do when no one else approves or rejects a commit that 
> we created ourselves? Or worse, when no one reviews at all?
> 
> My question applies mostly to QtDBus, since I don't expect most people will 
> know anything about that module. I've (ab)used Stephen's goodwill to review 
> simple things, but I don't expect him to understand the message delivery path 
> for example.
> 
> What is the suggested procedure?

Code reviews, in general, are good. Even by people that don't necessarily know the code.

I think it would be fine to +2 yourself after you gathered +1s, if you can't get +2s in any other way.

Cheers,


João