[Development] qHash / QHash changes

Olivier Goffart olivier at woboq.com
Tue Apr 17 09:59:57 CEST 2012


On Sunday 15 April 2012 20:38:22 Thiago Macieira wrote:
> On segunda-feira, 16 de abril de 2012 00.08.43, Olivier Goffart wrote:
> > On Saturday 14 April 2012 20:06:53 Giuseppe D'Angelo wrote:
> > > So, after *too many* commits[1] -- QHash randomization was merged a
> > > few hours ago!
> > > 
> > > https://qt.gitorious.org/qt/qtbase/commit/c01eaa438200edc9a3bbcd8ae1e8de
> > > d0
> > > 58 bea268
> > > 
> > > Thanks to all of the guys involved for the ideas, feedback, reviewing
> > > the patches... and staging them :-)
> > 
> > Nice work!
> > 
> > I'm just not really happy with the fact that you removed the optimisation
> > for int to avoid storing both the hash and the key.
> 
> It was stored as the same field because hash and key were the same.
> 
> if you salt the hash, it's no longer the same. Therefore, they can't share a
> field.

By not salting the hash for integer.
Or only doing it before applying the %



More information about the Development mailing list