[Development] qHash / QHash changes

Oswald Buddenhagen oswald.buddenhagen at nokia.com
Tue Apr 17 12:46:31 CEST 2012


On Tue, Apr 17, 2012 at 09:59:57AM +0200, ext Olivier Goffart wrote:
> On Sunday 15 April 2012 20:38:22 Thiago Macieira wrote:
> > On segunda-feira, 16 de abril de 2012 00.08.43, Olivier Goffart wrote:
> > > I'm just not really happy with the fact that you removed the optimisation
> > > for int to avoid storing both the hash and the key.
> > 
> > It was stored as the same field because hash and key were the same.
> > 
> > if you salt the hash, it's no longer the same. Therefore, they can't share a
> > field.
> 
> By not salting the hash for integer.
> Or only doing it before applying the %
>
as i said in one of the related changes, the salted and still optimized
version would simply re-salt the hash/value union upon reading the
value. as it's a xor and we store the salt, it's 100% reversible, and
adds hardly any overhead.



More information about the Development mailing list