[Development] Qt5 build issue for Harmattan

[Sean Harmer]

On Saturday 25 August 2012 13:02:34 Sean Harmer wrote:
> On Saturday 25 August 2012 12:54:06 Sean Harmer wrote:
> > On Saturday 25 August 2012 12:45:10 Laszlo Papp wrote:
> > > > We cannot really fix this within Qt as each implementation is free to
> > > > 
> > > >> define
> > > >> GLchar to whatever they like within the confines of the spec. Usually
> > > >> it's
> > > >> just a typedef to char but that is not necessarily always the case.
> > > > 
> > > > I would personally appreciate a solution upstream, if possible. I
> > > > know,
> > > > Harmattan is not a tier 1 platform, and will probably never be, but it
> > > > is
> > > > a
> > > > regression for the build either way. We have had working builds
> > > > before.
> > > 
> > > The code already has an entry like this:
> > > 
> > > # ifndef GLdouble
> > > typedef GLfloat GLdouble;
> > > # endif
> > 
> > Yes and that is on my list of things to see if we can remove. I left it
> > present in the patch you referenced to play it safe.
> > 
> > > I can submit a patch to gerrit like this:
> > > 
> > > # ifndef GLchar
> > > typedef GLbyte GLchar;
> > > # endif
> 
> We need to do this on a per-platform basis as GLchar is a typedef not a
> #define. I'm looking at this now. Unfortunately I see no Q_OS_MAEMO in
> qplatformdetection.h.

Please test the patch at https://codereview.qt-project.org/#change,33551

Cheers,

Sean
--
Dr Sean Harmer | sean.harmer at kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions