[Development] Maintainer changes to review: QMutex optimisations

lars.knoll at nokia.com lars.knoll at nokia.com
Sat Aug 25 21:20:43 CEST 2012


Just went through them all. In general, feel free to ping me if you need a review. I might not always be able to help, but I'll try :)

Cheers,
Lars

On Aug 25, 2012, at 9:40 AM, ext Thiago Macieira <thiago.macieira at intel.com> wrote:

> Hello
> 
> While the discussion on the change to the commit policy is ongoing, I'd like 
> to use some of the provisions I made there:
> 
> "a Maintainer may self-approve a change even if there are no +1s at all, 
> provided that there are no -1s either, and provided that the Maintainer post 
> to the mailing list asking about it and there are still no positive reviews 
> after reasonable time."
> 
> The following changes belonging to topic branch "qmutex-optim" in qtbase are 
> in need of reviewing:
> 	https://codereview.qt-project.org/32596
> 	https://codereview.qt-project.org/32597
> 	https://codereview.qt-project.org/32599
> 	https://codereview.qt-project.org/32600 (one +1 already)
> 	https://codereview.qt-project.org/32601
> 	https://codereview.qt-project.org/32611 (one +1 already)
> 
> The changes were first uploaded 2 weeks ago. The last update to the code was 9 
> days ago.
> 
> My two usual suspects for QMutex changes have been unavailable: Olivier has 
> been MIA this week, so I suspect he's busy; Brad is away on parental leave.
> 
> If no +1 or +2 comes within reasonable time, I will self-approve the changes 
> above.
> 
> PS: I've just maintainer-approved the following changes based on the existence 
> of a +1, no objections and no activity in 9 days:
> 	https://codereview.qt-project.org/32071
> 	https://codereview.qt-project.org/32926
> -- 
> Thiago Macieira - thiago.macieira (AT) intel.com
>  Software Architect - Intel Open Source Technology Center
>     Intel Sweden AB - Registration Number: 556189-6027
>     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development




More information about the Development mailing list