[Development] [Qt-creator] gerrit-speak

Thiago Macieira thiago.macieira at intel.com
Fri Dec 14 17:05:40 CET 2012

On sexta-feira, 14 de dezembro de 2012 19.55.03, Konstantin Tokarev wrote:
> > I often read it as "it must be as small as possible" and sometimes my
> > commits are not testable by themselves.
> In my understanding, "small as possible" means "can be cherry-picked on its
> own"

Again, that's not how I read it. I read "atomic" as "one commit, one change" 
even if that change makes it not compile or not pass tests. I try to avoid 
that, of course, but when doing a series of changes, I find it acceptable.
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20121214/4c2b3226/attachment.sig>

More information about the Development mailing list