[Development] QTBUG-23489: Implement the new regular expression classes using PCRE

[Shaw Andy]

On 2/22/12 9:48 PM, "Thiago Macieira" <thiago at kde.org> wrote:

>On quarta-feira, 22 de fevereiro de 2012 17.11.17, lars.knoll at nokia.com
>wrote:
>> Hi,
>> 
>> this is the first mail where I'd like to go through the remaining
>>features
>> for Qt 5.0.
>> 
>> I know that this bug is blocked by not having PCRE in 3rdparty/. But how
>> is the status apart from this? Thiago, simply tell me if you feel
>> comfortable with the code and I'll do final review and approval. If it
>> doesn't break BC and is standalone from other code in qtcore, it can go
>> into master, otherwise I'd prefer it to go into api_changes.
>
>I'm comfortable with the code as-is. Peppe has already submitted a couple
>of 
>changes on top, which fix issues he's already found. Arguably, they could
>be 
>squashed together, but I don't think that matters.
>
>The one remaining issue is the use of mutex-protected data. But I think
>we've 
>got the proper fix in already. We'll only know more once people start
>using it.
>
>> There's another related issue to this bug: What do we do with the old
>> QRegExp? I've gripped through our code and removing it is a larger
>> surgical operation.
>
>Indeed. I really have no clue how hard this would be.
>
>The uses of QRegExp in qtbase and my proposals would be:
>
> - qmake: lots of use, keep it by copying qregexp.cpp into qmake

Since I understand that the code would still be available in a separate
library anyway, then there is no need to copy the file, qmake pulls in the
files it needs directly from the current location so it could just
continue to do the same without having to copy the qregexp.cpp
specifically.

Andy