[Development] Fixing connecting to private signals

Thiago Macieira thiago.macieira at intel.com
Wed Jul 11 18:40:10 CEST 2012


On quarta-feira, 11 de julho de 2012 18.13.07, Stephen Kelly wrote:
> Hi there,
> 
> With the function-pointer-based QObject::connect syntax, it is currently not
> possible to connect to the private signals on QAbstractItemModel
> (rowsInserted() etc), QAbstractState (entered() and exited()) and
> QAbstractTransition (triggered()).
> 
> Patches for fixing that are here:
> 
> * https://codereview.qt-project.org/#change,30372
> * https://codereview.qt-project.org/#change,30337
> * https://codereview.qt-project.org/#change,30434
> 
> Without them, it will not be possible throughout Qt 5.x releases to connect
> to those signals with the function pointer syntax.
> 
> Reviewing has dried up after addressing some trivial stuff on the first
> patch, so I'm asking for new reviewers so we can get them into the repo and
> fix the function pointer based connects.

I don't see the point of a private signal.

QAbstractitemModel is abusing it. Just make them regular signals.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120711/917fcc8a/attachment.sig>


More information about the Development mailing list