[Development] Moving QWindowSystemInterface out of QPA

lars.knoll at nokia.com lars.knoll at nokia.com
Thu Jul 19 16:16:44 CEST 2012


On 7/16/12 12:43 PM, "ext Stephen Kelly" <stephen.kelly at kdab.com> wrote:

>On Sunday, July 15, 2012 14:24:18 Holger Hans Peter Freyther wrote:
>> On Tue, Jul 10, 2012 at 11:53:33AM +0200, Thiago Macieira wrote:
>> > We have only two choices:
>> > 
>> > 1) make QWindowSystemInterface a proper, public API class
>> 
>> I think QWindowSystemInterface in its current form would be
>> a rather incomplete and limited API.
>
>The point you have to keep in mind is that it can be extended: There are
>no 
>virtual methods on it, and no reason to add any, and it doesn't have a
>virtual 
>destructor, so it is not designed to be subclassed (actually it should be
>a 
>namespace instead of a class).
>
>So whether the API doesn't offer enough for you is beside the point - the
>point (and the problem) is that it appears in public headers.

Yes, and we should fix that. QTestLib uses three methods from QWSI. That
doesn't sound like a good enough reason to make around 30 methods public.

The class in it's current state is somewhat messy, and we might want to or
need to change the signatures of methods in there in the future.

Cheers,
Lars




More information about the Development mailing list