[Development] Help reviewing my own changes to QSharedPointer

[lars.knoll at nokia.com]

On 6/6/12 6:53 PM, "ext Thiago Macieira" <thiago.macieira at intel.com> wrote:

>Cf. thread: Maintainer "TrustMes"
>http://lists.qt-project.org/pipermail/development/2012-April/002930.html
>http://comments.gmane.org/gmane.comp.lib.qt.devel/2953
>
>I need help again reviewing my own changes. Since I am the maintainer of
>the 
>module that the changes are going to, there's no one else to call upon. I
>asked Lars and he said he can't safely review them. I'm asking the
>community 
>here to help out.
>
>The first two changes are extremely important and must be done before 5.0:
>
>https://codereview.qt-project.org/26974 - Remove "delete value"
>https://codereview.qt-project.org/26975 - Remove virtuals from the private
>
>The next few changes are cleanups:
>https://codereview.qt-project.org/26977 - Merge two private classes
>https://codereview.qt-project.org/26978 - Merge the private to the public
>https://codereview.qt-project.org/26979 - Use the copy & swap trick
>
>Then there are some optimisations:
>https://codereview.qt-project.org/26980 - Optimise the constructor

Got until the change above and gave up for today at the next one. Will get
back to it tomorrow.

>https://codereview.qt-project.org/26981 - Optimise deletion

I might be wrong (getting tired), but I think this reintroduces the
problem with forward declared pointers that the first patch fixes.

Cheers,
Lars

>
>One new feature (we should leave for 5.1):
>https://codereview.qt-project.org/26982 - Add create() with variadic
>arguments 
>and perfect forwarding
>
>And one unit test:
>https://codereview.qt-project.org/27043 - lambda as custom deleter
>
>-- 
>Thiago Macieira - thiago.macieira (AT) intel.com
>  Software Architect - Intel Open Source Technology Center
>     Intel Sweden AB - Registration Number: 556189-6027
>     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
>_______________________________________________
>Development mailing list
>Development at qt-project.org
>http://lists.qt-project.org/mailman/listinfo/development