[Development] Help reviewing my own changes to QSharedPointer

[Thiago Macieira]

On quinta-feira, 7 de junho de 2012 06.47.11, lars.knoll at nokia.com wrote:
> >The new optimisation does not introduce "delete value" into the reference-
> >dropping code path. That is still:
> >
> >       d->destroy()
> >which does:
> >        void destroy() { destroyer(this); }
> >       (destroyer is a function pointer)
> >
> >The optimisation simply changes what the pointed function does. Wiithout
> >it, 
> >it will call another stored function pointer. With it, it will call
> >delete 
> >directly.
> 
> You're right. My brain probably stopped working shortly before midnight.
> Will review the remaining patches today as well.

I've just had an idea to make this optimisation slightly more generic. I need 
to experiment a little to see if it's worth it. If it is, I'll send a 
replacement and let reviewers judge which one is better.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120607/7aafc8ad/attachment.sig>