[Development] New QUrl reviewing

[marius.storm-olsen at nokia.com]

Eh, after alpha please?

-- 
.marius


> -----Original Message-----
> From: development-bounces+marius.storm-olsen=nokia.com at qt-
> project.org [mailto:development-bounces+marius.storm-
> olsen=nokia.com at qt-project.org] On Behalf Of Knoll Lars (Nokia-MP/Oslo)
> Sent: Thursday, March 29, 2012 6:56 AM
> To: thiago.macieira at intel.com; development at qt-project.org
> Subject: Re: [Development] New QUrl reviewing
> 
> All is reviewed. Stage at your convenience ;-)
> 
> Cheers,
> Lars
> 
> On 3/28/12 11:42 PM, "ext Thiago Macieira" <thiago.macieira at intel.com>
> wrote:
> 
> >On quarta-feira, 28 de março de 2012 19.08.04, lars.knoll at nokia.com wrote:
> >> I'll try to go through them tonight.
> >
> >Thanks for the effort. I've gone over all the recommendations and made
> >the
> >modifications. We're pending further work on:
> >
> >1) QUrlTwoFlags - a helper class like QFlags but that takes two enums not
> >just
> >one. I'll simplify this into QFlags if possible and make it generic later.
> >
> >2) renaming the QUrlQuery methods (i.e., API review). The names were
> kept
> >equal to Qt 4's for compatibility reasons, but since this is a new class
> >and
> >you need to touch your code anyway to use them, we could use better
> >names.
> >Will do after they code is in.
> >
> >3) decide if QUrl::errorString() should be translatable
> >
> >One of the changes has already been staged (the one in qtdeclarative).
> >The
> >rest have been updated with the fixes. All the commits have two changes
> >except
> >the first two below: the first is just a rebase because Gerrit required
> >me to
> >rebase. The second contains the modifications.
> >
> >To be re-approved or reviewed for the changes:
> >http://codereview.qt-project.org/21045 only rebase - Gerrit shows no
> >changes
> >http://codereview.qt-project.org/21046 only rebase - Gerrit shows no
> >changes
> >http://codereview.qt-project.org/21047 updated the constants to be
> higher
> >http://codereview.qt-project.org/21048 only rebase - Gerrit shows no
> >changes
> >http://codereview.qt-project.org/21052 renamed encodedUtf8ToUcs4 to
> *Utf16
> >http://codereview.qt-project.org/21049 two changes requested by Lars
> >http://codereview.qt-project.org/21057 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21056 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21058 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21060 improvements and test requested
> by
> >Lars
> >http://codereview.qt-project.org/21061 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21063 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21064 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21066 changes but Gerrit shows
> unrelated
> >too
> >http://codereview.qt-project.org/21067 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21068 only rebase - Gerrit shows
> >unrelated
> >http://codereview.qt-project.org/21751 new change
> >
> >--
> >Thiago Macieira - thiago.macieira (AT) intel.com
> >  Software Architect - Intel Open Source Technology Center
> >     Intel Sweden AB - Registration Number: 556189-6027
> >     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
> >_______________________________________________
> >Development mailing list
> >Development at qt-project.org
> >http://lists.qt-project.org/mailman/listinfo/development
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development