[Development] Proposing reversal of the Math3D qreal->float change

Sean Harmer sean.harmer at kdab.com
Mon Sep 17 11:09:14 CEST 2012


On Thursday 13 September 2012 10:30:47 Thiago Macieira wrote:
> On terça-feira, 11 de setembro de 2012 22.44.52, Sean Harmer wrote:
> > On 11/09/2012 22:39, Thiago Macieira wrote:
> > > On terça-feira, 11 de setembro de 2012 22.34.50, Sean Harmer wrote:
> > >> I propose we (I) fix the affected classes in QtMultimedia and Qt3D. I'm
> > >> away on business this week but I will make a start asap.
> > > 
> > > Qt3D is now passing.
> > 
> > Yes it is passing. I will prepare a patch to remove the usage of qreal
> > and see if the maintainer of that module agrees with it or not and take
> > it from there.
> > 
> > > I'll correct the compilation errors for QtMultimedia, but not the tests.
> > > If
> > > tests show failures, we'll wait for you or someone else.
> > 
> > OK, thank you. I'll do my best to address any failures in a timely manner.
> 
> QtMultimedia compiled and passed the tests.

Thanks. Over the weekend I merged patches to switch Qt3D to use float 
throughout. 

https://codereview.qt-project.org/#change,34902
https://codereview.qt-project.org/#change,34905

I will now look at removing the insignificant markers that were recently added 
to a few tests there.

Cheers,

Sean
--
Dr Sean Harmer | sean.harmer at kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions



More information about the Development mailing list