[Development] kdelibs coding style

Oswald Buddenhagen oswald.buddenhagen at digia.com
Tue Apr 30 18:47:33 CEST 2013


On Tue, Apr 30, 2013 at 09:01:51AM -0700, Thiago Macieira wrote:
> On segunda-feira, 29 de abril de 2013 23.30.59, André Pönitz wrote:
> > The rules are ok as they are (pretty much as _any_ set of consistently
> > applied and not-completely-weird rules). Opening them up only leads to
> > more review bikeshedding.
> > 
> > It's not that people actively change coding style in old Qt code, and
> > there's always the "don't stick to the rules if it makes you look bad"
> > excuse.
> 
> Let's not try to change any of the rules, since this leads to bikeshedding, 
> like André said. It clearly has already become that.
> 
so let's meta-bikeshed instead?

> So let's just change the interpretation: the "don't stick to the rules" allows 
> us to accept a slightly different style if that makes it nicer. That should be 
> enough to apply to the case of braces in single-line ifs.
> 
now, that is kinda ridiculous. the cop-out rule exists to justify
exceptions in corner cases, not to give everyone a free pass for their
coding style preferences.

on a personal note, while i strongly sympathize with the diff
minimization philosophy, i also feel quite a dislike for excess braces.
adding to that the in this case pretty persuasive consideration of the
status quo, i'd like this discussion to die. NOW.



More information about the Development mailing list