[Development] QWindowsWindow destructor runs nested event loop

[Frans Klaver]

Hi all,

As already shortly discussed on the interest mailing list [1], the
QWindowsWindow destructor is flushing window system events. This is
causing a nested event loop run, which in general is considered a bad
idea. Below an excerpt from my earlier reply there.

This flush was introduced in relation to QTBUG-26903 [2] (which is
about the initial window placement) in patch set 5 [3]. It features a
note stating that it "looks unrelated but hopefully fixes the CI
problems". It hasn't been removed afterwards. I guess this suggests
this line could be removed without causing any trouble? Could Shawn or
Gunnar (resp. author and reviewer) comment on this?

Thanks,
Frans

[1] http://lists.qt-project.org/pipermail/interest/2013-August/008142.html
[2] http://bugreports.qt-project.org/browse/QTBUG-26903
[3] https://codereview.qt-project.org/#patch,sidebyside,44080,5,src/plugins/platforms/windows/qwindowswindow.cpp