[Development] epoll event dispatcher

Oswald Buddenhagen oswald.buddenhagen at digia.com
Tue Aug 13 18:11:50 CEST 2013

On Tue, Aug 13, 2013 at 08:50:50AM -0700, Thiago Macieira wrote:
> On terça-feira, 13 de agosto de 2013 13:54:36, Oswald Buddenhagen wrote:
> > > Hmm.  I think the patch more or less follows the existing practice in 
> > > the changed files.  It appears they haven't been cleaned up to match the 
> > > coding standard.
> > 
> > yes, there is quite some "legacy" coding style in qt. we are fixing it
> > up incrementally by making new/changed code compliant with the style.
> > bulk changes (in particular to kill off tabs) have been considered, but
> > nobody pushed it through so far. please check the list archives for
> > relevant discussions.
> Better yet: http://qt-project.org/wiki/Qt_Coding_Style
that doesn't explain why we didn't bulk-fix it. ;)

> Ossi: you may have missed the part where I said that the contributor's
> company did not accept the CLA. The contributor (Florian) will not
> upload it to Gerrit.
that doesn't prevent him from posting updated patches to jira and
logging in to gerrit to get feedback once the changes are uploaded.

More information about the Development mailing list