[Development] Proposal: Allow contributors to +1 sanity review.

Laszlo Papp lpapp at kde.org
Wed Aug 14 11:00:55 CEST 2013

On Wed, Aug 14, 2013 at 8:44 AM, Giuseppe D'Angelo <dangelog at gmail.com>wrote:

> On 13 August 2013 23:18, Alan Alpert <416365416c at gmail.com> wrote:
> >
> > To be clear, this discussion is not about altering the functionality
> > of the sanity bot. The current discussion is about the Gerrit
> > interface to the sanity review field. If there were any use for that
> > field other than the bot, then we wouldn't end up having the two
> > conversations so closely tied together.
> >From another prospective: if the contributor can't approve the patch,
> what's the point to allow him/her to override the bot's -1? If it's a
> mistake, it can be noted in a comment, so the approver can judge it
> and eventually override that.

Agree with Giuseppe and Kai. I also think that these decisions are
orthogonal, and better up to an approver.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130814/55e02d32/attachment.html>

More information about the Development mailing list