[Development] Reviews needed before android integration in two weeks

[Thomas McGuire]

Hi,

On Wednesday 06 February 2013 13:05:33 Paul Olav Tvete wrote:
> On Wednesday 6 February 2013 09:41:46 Paul Olav Tvete wrote:
> > On Wednesday 6 February 2013 09:00:41 Thomas McGuire wrote:
> > > A workaround would be to squash all commits of the branch together into
> > > a single patch and then upload that to Gerrit for review. Now,
> > > actually pushing  the single patch would lose history, so we'd instead
> > > manually do a
> > > proper merge of the branch. How about we do that for the Android merge?
> > 
> > That's a great idea! We can push a squashed commit as a WIP to gerrit. I
> > think we should do a preliminary one this week. (And yes, this is a "we
> > should" that means "I will" in the old Trolltech tradition :)
> 
> Here is a squashed commit of all changes to qtbase, for those who like to
> see everything in one place:
> https://codereview.qt-project.org/#change,46976
> 
> qtdeclarative: https://codereview.qt-project.org/#change,46983
> qtsensors: https://codereview.qt-project.org/#change,46984

Thanks, that is quite helpful. Discovered some more things during the review 
on Gerrit.

Regards,
Thomas
-- 
Thomas McGuire | thomas.mcguire at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130206/359b3fa4/attachment.sig>