[Development] Reviews needed before android integration in two weeks

Olivier Goffart olivier at woboq.com
Wed Feb 6 21:13:36 CET 2013


About https://codereview.qt-project.org/46798

On Wednesday 06 February 2013 11:51:17 BogDan wrote:
> I think I understood how the event loop is supposed to work, sadly, at least
> on android, it doesn't work as it should. Is very simple to check it, just
> revert that patch and test an UI application that doesn't have any active
> timer, you should see the missing events immediately when you tap on the
> device (push a button or something). I didn't said is a deadlock, what
> I'm trying to say is that the event loop doesn't wake up immediately.

But why is select blocking if there is something to read on that file 
descriptor?
Normally, select should return immediatly in that case.

That said, it is probably a good idea not to call select at all when it is not 
needed.  But with that patch, you also make calls to write even when it is not 
needed, while before there was only call to write.

-- 
Olivier

Woboq - Qt services and support - http://woboq.com



More information about the Development mailing list