[Development] [Releasing] Including QTimeZone in Qt 5.1

John Layt jlayt at kde.org
Thu Feb 28 10:49:02 CET 2013


On Wednesday 27 Feb 2013 13:49:48 Thiago Macieira wrote:
> On quarta-feira, 27 de fevereiro de 2013 20.57.22, John Layt wrote:

> > Currently is now dropped, we'll wait and see if there's any demand later.
> > It would actually be isDaylightTime(QDateTime::currentMSecsSinceEpoch()).
> 
> Then please change to use QDateTime.

OK, so you would prefer the API uses QDateTime everywhere instead of MSecs?  
That will make the QDateTime internal use less efficient with converting back 
and forth, but I guess I could make QDateTime a friend of the private so it 
directly accesses the MSecs methods.  I'll just need to be careful about 
setting up circular dependencies.

> > The thing with caching the System time zone is to prevent unexpected time
> > zone changes.  If the system time zone was to dynamically change then an
> > app could be left in an inconsistent state, with QDateTime instances
> > having
> > changed but gui strings and other cached details or calculations still
> > reflecting the old system time zone.  My thinking was that we would have a
> > QEvent::TimeZoneChange that the app would respond to by calling the reset.
> 
> You're creating an API call to resolve a problem of the implementation. That
> sounds wrong. Instead, solve the problem of the implementation.

OK, I'll talk to the PIM guys about how they would expect it to behave, but in 
the meantime I'll remove it from the public api.

Cheers!

John.




More information about the Development mailing list