[Development] QtMultimedia BIC / header cleanliness issue

[Knoll Lars]

Finally reading up on some old emails…

I'd say we add the virtual destructors. Better to deal with the fallout now then in the future.

Cheers,
Lars

On Dec 28, 2012, at 1:03 PM, Thiago Macieira <thiago.macieira at intel.com> wrote:

> On sexta-feira, 28 de dezembro de 2012 19.11.32, Sze Howe Koh wrote:
>> On 25 December 2012 01:35, Thiago Macieira <thiago.macieira at intel.com> 
> wrote:
>>> On segunda-feira, 24 de dezembro de 2012 06.30.58, Sascha Cunz wrote:
>>>> But strictly spoken, I would rather say no: BC is BC no matter what silly
>>>> mistakes it includes (I have actually had to deal with code that used the
>>>> above mentioned inheritance layouts).
>>>> OTOH, it's still very early in the life of released Qt5.
>>> 
>>> We can change the soname for the library. libQt5Multimedia.so.6.
>> 
>> I've never seen Qt DLLs that have additional numbers on Windows; is
>> the changing-soname approach acceptable on Windows and Mac?
> 
> It's acceptable on Mac, for the .dylib (non-framework) builds. For framework 
> builds as well as for Windows, we'd have to invent some new method.
> 
> On Windows, the Qt DLLs have always had the version number: QtCore4.dll and 
> Qt5Core.dll. However, we're now proposing separating the source version (5) 
> from the binary version (6).
> 
>> Whatever solution is taken, we'll need to add notes to the
>> documentation of both classes, either to say "Binary files that
>> include this interface are incompatible between Qt 5.0 and Qt 5.1", or
>> "This interface class contains a bug, do not perform a deletion
>> through it."
> 
> Agreed.
> 
> -- 
> Thiago Macieira - thiago.macieira (AT) intel.com
>  Software Architect - Intel Open Source Technology Center
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development