[Development] Repository is too open

[Jason McDonald]

On Tue, Jan 29, 2013 at 10:00 PM, Sergio Ahumada
<sergio.ahumada at digia.com> wrote:
> On 01/29/2013 12:57 PM, Jason McDonald wrote:
>> I think there is a problem here.  The announcement in the link seems
>> to indicate that the intention was only to present non-approvers with
>> a "Merge patchset x to Staging" button once the commit has at least
>> one +2.  I'm now seeing the merge button on commits without any +2's,
>> and even on commits where the only score is a -1.  For example, see
>> https://codereview.qt-project.org/#change,43299.
>>
>> IMO, we don't want over-eager contributors pressing that button and
>> staging a change before an approver has approved it.
>
> I sort of remember that if you try to stage/submit a change that doesnt
> have at least one +2 it should fail and give you an error message.
>
>> Granted, I am an approver, so I may not be seeing the same thing that
>> a non-approver does, but even so, I don't think an approver should be
>> able to stage an unapproved commit either.
>
> Maybe you can try and see if you get the error message .. if it gets
> staged ping me on IRC and I can unstage it :)

I wasn't game to press the button before, in case I staged something
that I couldn't then unstage right away.

Attempting to stage gives

Application Error
Server Error
Requires Code Review

...so it seems safe.

Still seems strange to present a button that the system already knows
is a dead-end, but I guess that's a P3, not a P1.

Cheers,
--
Jason