[Development] Dropping the variadic version of QSKIP
Albert Astals Cid
albert.astals at canonical.com
Wed Jul 10 15:09:41 CEST 2013
Hi all, in 14cd2678396ed1450a72aeffa99c1504743ea415 a variadic version of QSKIP
was added so that the old Qt4 version of
QSKIP(statement, mode)
would compile on C++11 enabled compilers silently ignoring the mode.
This has a down side, it is causing that code like
QSKIP("HOLA");
gives
warning: ISO C99 requires rest arguments to be used [enabled by default]
when compiled with -pedantic and C++11
Furthermore, things like
QSKIP("HOLA", SkipSingle);
don't compile anymore because moc complains
main.cpp:11: Error: Macro argument mismatch.
So it doesn't seem it makes much sense to keep the variadic version of QSKIP
to enable the compatibility with the old Qt4 syntax if moc is not accepting it
anymore.
Would you guys accept a patch that drops the variadic version of QSKIP?
Cheers,
Albert
More information about the Development
mailing list