[Development] Header diff for QtQml

Alan Alpert 416365416c at gmail.com
Thu Jun 27 06:30:17 CEST 2013

On Wed, Jun 26, 2013 at 8:10 PM, Thiago Macieira
<thiago.macieira at intel.com> wrote:
> On quarta-feira, 26 de junho de 2013 17.42.54, Alan Alpert wrote:
>> > Does it have a reason for the include? For example, does it declare
>> > debugging operators for anything? If not, it's probably accidental and
>> > can be safely removed.
>> It uses qWarning() in the definition of a new inline function (the url
>> form of qmlRegisterType). Sounds like it's okay to leave it there,
>> although the function could be un-inlined if the include is a problem.
> I'd prefer that. Or use the non-streaming version of qWarning(), which doesn't
> require qdebug.h (only qlogging.h, which is included from qglobal.h).

https://codereview.qt-project.org/#change,59948 implements the latter,
for your perusal.

Alan Alpert

More information about the Development mailing list