[Development] QtDriveInfo module in Playground

Laszlo Papp lpapp at kde.org
Sat Mar 2 17:05:38 CET 2013


On Fri, Mar 1, 2013 at 3:50 PM, Thiago Macieira
<thiago.macieira at intel.com>wrote:

> On sexta-feira, 1 de março de 2013 10.52.41, Olivier Goffart wrote:
> > qdisplayinfo_linux.cpp:50 is:
> > Q_GLOBAL_STATIC_WITH_ARGS(const QString, BACKLIGHT_SYSFS_PATH,
> >
> (QStringLiteral("/sys/class/backlight/")))
> >
>
> > Is that something we should fix in Q_GLOBAL_STATIC_WITH_ARGS ?  or should
> > we  jsut say that lambda expressions or QStringLiteral are not allowed in
> > Q_GLOBAL_STATIC_WITH_ARGS ?
>
> It's just too much overhead the way it's written. It's much simpler as:
>
> static QString backlightSysfsPath()
> {
>     return QStringLiteral("/sys/class/backlight/");
> }
>
> QStringLiteral is optimised for that case.
>

Actually, there was a change submitted about a month ago for this issue
apparently: https://codereview.qt-project.org/#change,46455

Laszlo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130302/43d0b839/attachment.html>


More information about the Development mailing list