[Development] White space / coding style patches welcome?

[Charley Bay]

Axel sayeth:
>
> >> <snip, whitespace-only changes for consistency to
> >> coding standard>


+1 YAY, Axel!

This is a personal wish by me -- consistency.  Including for whitespace.

I find it astounding the "legacy-code-bases" that essentially decide that
they cannot be improved -- no such patches are welcome -- because it would
require work, add merge conflicts, etc.  While those are real issues, the
result suggests the project *must* go "stale", and become increasingly
annoying/inconsistent.

I work in such systems.  And, that makes me sad.

Oswald respondeth:

> > <snip, patch welcome, should be consistent, probably
> > should be done periodically, and for incremental parts
> > of the code base as they can be addressed>


Seems like a sensible response.

Axel:

> <snip>,
> To summarize my suggestion:
>  * accept partly style fixes (in either type or file space)
>  * accept them on an a timely manner to make it feasible at all with
> regards to merge conflicts
>  * intentionally ignore stuff in src/3rdparty
>
> I might even be interested in looking into the automatic style check
> issue, but can't promise anything.
>

Sounds good.  Long-term, the automatic-style-check thing (e.g., scripts to
reformat upon check-in) would be ideal, but I realize that can be tricky.

It makes sense that we would eventually get the whitespace-formatting into
the tool-chain workflow, though.  I like where the CI-system and
review-process is going, and it seems like this is merely an extension of
that.

--charley
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130312/87bf7f08/attachment.html>