[Development] Qt 5.2 header diff: QtConcurrent

Marc Mutz marc.mutz at kdab.com
Tue Nov 5 11:25:48 CET 2013


On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> @@ -101,9 +102,10 @@ public:
>      {
>          if (dirty) {
>              dirty = false;
> -            QVector<T> sorted = values;
> -            qSort(sorted);
> -            currentMedian = sorted.at(bufferSize / 2 + 1);
> +            QVector<T> copy = values;
> +            typename QVector<T>::iterator begin = copy.begin(), mid =
> copy.begin() + bufferSize/2, end = copy.end(); +           
> std::nth_element(begin, mid, end);
> +            currentMedian = qMove(*mid);
>          }
>          return currentMedian;

Since reverted to just s/qSort/std::sort/:
   https://codereview.qt-project.org/70277
   https://codereview.qt-project.org/70276
because of mystical problems in QtCreator.

Thanks,
Marc



More information about the Development mailing list