[Development] Staging changes in release branch

Saether Jan-Arve Jan-Arve.Saether at digia.com
Thu Nov 14 09:55:32 CET 2013


Actually all of these failures shown in https://codereview.qt-project.org/#change,70990 seems to be caused by the following change:

http://codereview.qt-project.org/71009 [PS1] - Fix possible crashes in QTreeView

So I wouldn't say that it is caused by the tests...

Jan Arve



> -----Original Message-----
> From: development-bounces+jan-arve.saether=digia.com at qt-project.org
> [mailto:development-bounces+jan-arve.saether=digia.com at qt-project.org]
> On Behalf Of Antti Kokko
> Sent: 14. november 2013 07:54
> To: Heikkinen Jani; Sean Harmer; development at qt-project.org
> Cc: Knoll Lars
> Subject: Re: [Development] Staging changes in release branch
> Hi,
> 
> You can check more detailed logs about the failed test cases Jani
> listed below from this change, contains all the "fail variations":
> 
> https://codereview.qt-project.org/#change,70990
> 
> Br, Antti
> 
> On 11/14/2013 08:36 AM, Heikkinen Jani wrote:
>> Hi!
>> Yes, as Lars said there is of course whole release team who is
> helping Antti with this. At the moment biggest issue with this isn't
> staging itself but failing test cases and there we need your help.
> Maintainer/Someone who really understands needs to check those failing
> tests and either fix those or then with good reason skip/mark those
> insignificant. We in the release team cannot do that, we don't
> understand those tests well enough...
>> 
>> These tests are blocked integration lately:
>> 
>> tst_qgraphicsitem
>> tst_qqmlnotifier
>> tst_qgraphicsitem
>> tst_qvariant'
>> tst_qqmldebugjs
>> tst_languagechange
>> tst_qfiledialog
>> tst_qfiledialog2
>> tst_qtreewidget
>> tst_qtreewidgetitemiterator
>> 
>> br,
>> Jani
>> 
>>> -----Original Message-----
>>> From: development-bounces+jani.heikkinen=digia.com at qt-project.org
>>> [mailto:development-bounces+jani.heikkinen=digia.com at qt-project.org
>>> ]
>>> On Behalf Of Sean Harmer
>>> Sent: 13. marraskuuta 2013 21:47
>>> To: development at qt-project.org
>>> Cc: Knoll Lars
>>> Subject: Re: [Development] Staging changes in release branch
>>> 
>>> Hi Lars,
>>> 
>>> On Wednesday 13 November 2013 19:33:59 Knoll Lars wrote:
>>>> On 13/11/13 18:49, "Sean Harmer" <sean.harmer at kdab.com> wrote:
>>>>> Hi,
>>>>> 
>>>>> On Tuesday 12 November 2013 12:46:46 Heikkinen Jani wrote:
>>>>>> Hi all,
>>>>>> 
>>>>>> We have agreed in release team that Antti Kokko (irc: ankokko)
>>>>>> will
>>>>>> 
>>>>>> monitor
>>>>>> 
>>>>>> all approved changes in release branch and stage all clear ones
>>>>>> (fixes
>>>>>> 
>>>>>> for
>>>>>> 
>>>>>> P1 & P0 issues) automatically. Unclear changes (p2 or lower +
>>>>>> changes without bug ID) will be handled case by case by change
>>>>>> owner + release
>>>>>> 
>>>>>> team
>>>>>> 
>>>>>> (Antti will host discussion via email).
>>>>>> 
>>>>>> For you who didn't know: Antti started 1.11.2013 in release team
>>>>>> in
>>>>>> 
>>>>>> Oulu. A
>>>>>> 
>>>>>> lot of work and challenging tasks for him right from the start are
>>>>>> the
>>>>>> 
>>>>>> best
>>>>>> 
>>>>>> way to learn. Whole release team will support Antti with all this!
>>>>> First of all thanks to Antti for taking this on. However, is it
>>>>> wise to have a single person be responsible for this? The issue
>>>>> is that we are still dealing with a CI system that see's issues
>>>>> with tests meaning that some changes take several attempts to get
>>>>> through the CI even if the change is good.
>>>>> 
>>>>> Right now there are no changes either staged or integrating which
>>>>> is wasting the precious little time we have before the RC is
>>>>> tagged.
>>>>> 
>>>>> I would therefore like to request that we have more than one
> person
>>> able
>>>>> to
>>>>> stage changes to help cover times when Antti is not available.
>>>> I believe we¹re already doing this. Antti helps to coordinate and
>>>> stage what he can. But other members of the release team and
>>>> myself can (and
>>>> are) also staging during other hours for the stuff that¹s clear.
>>> OK great thanks. When you get a chance could you stage these please?
>>> 
>>> https://codereview.qt-project.org/#change,70916
>>> https://codereview.qt-project.org/#change,70848
>>> 
>>> These have both independently seen the same failure which we think is
>>> totally unrelated.
>>> 
>>> Also:
>>> 
>>> https://codereview.qt-project.org/#change,71036
>>> https://codereview.qt-project.org/#change,71022
>>> 
>>> are both related and can go in together.
>>> 
>>> The following were made by Marc following his analysis earlier today:
>>> 
>>> https://codereview.qt-project.org/#change,71141
>>> https://codereview.qt-project.org/#change,71142
>>> https://codereview.qt-project.org/#change,71143
>>> 
>>> and can all go in together.
>>> 
>>> Then for QtDeclarative:
>>> 
>>> https://codereview.qt-project.org/#change,70917
>>> 
>>> should also hopefully pass all tests now and so could do with another
>>> spin please.
>>> 
>>> Thanks,
>>> 
>>> Sean
>>> --
>>> Dr Sean Harmer | sean.harmer at kdab.com | Managing Director UK
>>> Klarälvdalens Datakonsult AB, a KDAB Group company Tel. Sweden (HQ)
>>> +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - Qt Experts -
>>> Platform-independent software solutions
>>> _______________________________________________
>>> Development mailing list
>>> Development at qt-project.org
>>> http://lists.qt-project.org/mailman/listinfo/development
>> _______________________________________________
>> Development mailing list
>> Development at qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/development
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development


More information about the Development mailing list