[Development] the need to add a Task-Number in the release branch ...
Kai.Koehne at digia.com
Thu Nov 14 14:27:42 CET 2013
Kai Köhne, Senior Software Engineer - Digia, Qt
Digia Germany GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Tuula Haataja
Registergericht: Amtsgericht Charlottenburg, HRB 144331 B
> -----Original Message-----
> From: development-bounces+kai.koehne=digia.com at qt-project.org
> [mailto:development-bounces+kai.koehne=digia.com at qt-project.org] On
> Behalf Of Knoll Lars
> Sent: Thursday, November 14, 2013 2:19 PM
> To: Buddenhagen Oswald; development at qt-project.org
> Subject: Re: [Development] the need to add a Task-Number in the release
> branch ...
> On 14.11.13 13:50, "Oswald Buddenhagen"
> <oswald.buddenhagen at digia.com>
> >On Thu, Nov 14, 2013 at 07:52:27AM +0000, Knoll Lars wrote:
> >> On 13.11.13 13:38, "Oswald Buddenhagen"
> >><oswald.buddenhagen at digia.com>
> >> >or to put is a bit concisely, the proposal is to simply pay
> >> >attention
> >> >the existing rules consistently instead of creating an entirely
> >> >unnecessary "paper trail".
> >> I agree with the proposal.
> >> But if there¹s no associated JIRA task, the commit message has to be
> >> clear and state why this change belongs into the release branch.
> >> Comments in gerrit are not good enough, as they are hard to trace.
> >this is exactly what this was supposed to preempt:
> Huh? I was saying that I don't think we need to create JIRA tasks.
> The commit message should always be clear, but if there's no associated task,
> you probably need a bit of extra argumentation in there.
I guess what Ossi was wondering about was ' the commit message [should] state why this change belongs into the release branch' . It would be IMO weird to have sentences starting with 'This patch has to go into the release branch because ...' in the commit message. This reasoning (if it's not immediately clear from the commit itself) can happen in gerrit.
In general I think we agree that any commit message in the release branch should get more attention than say in the dev branch, and that the rule should be 'if in doubt, create a JIRA task.'. But I'm also in favor of having this as a rule of thumb, instead of a hard rule.
My 2 cents
More information about the Development