[Development] Qt 5.3 header diff: QtCore
Thiago Macieira
thiago.macieira at intel.com
Wed Apr 23 02:00:15 CEST 2014
Em ter 22 abr 2014, às 16:34:09, Thiago Macieira escreveu:
> > --- a/src/corelib/kernel/qobject.h
> > +++ b/src/corelib/kernel/qobject.h
> > @@ -549,6 +549,83 @@ template <class T> inline const char *
> > qobject_interface_iid()>
> >
> > Q_CORE_EXPORT QDebug operator<<(QDebug, const QObject *);
> > #endif
> >
> > +class Q_CORE_EXPORT QSignalBlocker
>
> The class is entirely inline. Drop the Q_CORE_EXPORT.
https://codereview.qt-project.org/83865
> > --- a/src/corelib/tools/qchar.h
> > +++ b/src/corelib/tools/qchar.h
> > +#if QT_DEPRECATED_SINCE(5, 3)
> > + QT_DEPRECATED inline Joining joining() const {
>
> Bad coding style. The { needs to be on the next line. Same for qstring.h.
https://codereview.qt-project.org/83866
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
More information about the Development
mailing list