[Development] Qt 5.3 header diff: QtNetwork

Peter Hartmann phartmann at blackberry.com
Wed Apr 23 12:13:34 CEST 2014


On 04/22/2014 11:57 PM, Sune Vuorela wrote:
> On 2014-04-22, Thiago Macieira <thiago.macieira at intel.com> wrote:
>> --- a/src/network/ssl/qsslconfiguration.h
>> +++ b/src/network/ssl/qsslconfiguration.h
>> @@ -131,6 +132,21 @@ public:
>> +    static const char NextProtocolSpdy3_0[];
>> +    static const char NextProtocolHttp1_1[];
>
> These static const char[] kind of triggers my 'something looks wrong and
> not like Qt is supposed to look like'-feeling. I haven't investigated
> what they are for or how they are set and used. It just looks wrong to
> me.

The static const char[]s are what we came up with to support both 
predefined values as well as user-defined values for negotiating the 
Next Protocol in the SSL handshake, see 
https://codereview.qt-project.org/#change,64081,patchset=5 and the 
following patch sets for the discussion...

Peter

>
> /Sune
>
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>




More information about the Development mailing list