[Development] Removing QT_NO_DEBUG_STREAM?

[Koehne Kai]

Hi,

Today I've stumbled another time over QT_NO_DEBUG_STREAM ... you know, one of this infamous QT_NO macros that we keep 'alive' by mere copy and paste :) And because it's a new year, a new dawn , etc, I decided to do something about it.

- I'm pretty sure nobody could compile QtCore with QT_NO_DEBUG_STREAM since at least 2009 ... see e.g. QTBUG-18418 . Right now it errors right at  qstring.cpp.

- I'd like to replace most qDebug() qWarning() calls with their qCDebug()/qCWarning() equivalents inside Qt , which would result in a whole lot of #ifdef'ing if we keep QT_NO_DEBUG_STREAM

So, anyone would mind if I remove QT_NO_DEBUG_STREAM from the code base? I already started to do so for QtCore: https://codereview.qt-project.org/#change,74745 . But it's a lot of (tedious) work to do for the other modules too, so I thought I'd ask for opinions here before wasting more time :)

Regards

Kai

PS: A less invasive patch would be to only check for QT_NO_DEBUG_STREAM when it comes to operator<< for data types outside of QtCore. Anyway, given that we don't have the check in the CI I'm pretty sure it'll break over time, again.

-- 
   Kai Köhne, Senior Software Engineer - Digia, Qt
   Digia Germany GmbH, Rudower Chaussee 13, D-12489 Berlin
   Geschäftsführer: Mika Pälsi, Juha Varelius, Tuula Haataja
   Registergericht: Amtsgericht Charlottenburg, HRB 144331 B