[Development] Proposing Valerio Valerio (VDVsx) for Approver rights to messagingframework

[Knoll Lars]

On 23/01/14 00:32, "Thiago Macieira" <thiago.macieira at intel.com> wrote:

>On quarta-feira, 22 de janeiro de 2014 22:50:49, Robin Burchell wrote:
>> Hello,
>> 
>> I'd like to propose Approver rights for Valerio on messaging framework.
>> 
>> Justification: Valerio has worked on (& with) QMF for a long time, on
>> both the Nokia N9 and now with us at Jolla on QMF-on-Sailfish. QMF
>> also doesn't exactly have an abundance of approvers, so especially now
>> that I'm doing some work at the moment, having an 'extra pair of
>> hands' able to review would be handy.
>> 
>> Dashboard link: https://codereview.qt-project.org/#dashboard,1001065
>> (+ the git history for his time before the Gerrit import)
>
>+1 on that. The question is whether he should be given approver rights
>throughout or just in QMF, considering he hasn't done any Qt contribution
>outside of QMF.
>
>However, knowing Valerio from the past, I would be ok with giving him
>approver 
>rights throughout.

+1 (including the last sentence).

Cheers,
Lars