[Development] [Qt-creator] Gerrit disapproval messages

Thiago Macieira thiago.macieira at intel.com
Sun Jan 26 20:41:39 CET 2014


On domingo, 26 de janeiro de 2014 18:31:18, Tomasz Siekierda wrote:
> > The scores are now:
> > -1 - I would prefer this is not merged as is
> > -2 - This shall not be merged
> > 
> > I suggest configuring qt-project gerrit to something similar.
> > 
> > Opinions?
> 
> A big +1 from me. I know this might sound unimportant or even silly
> for people with some Gerrit experience, but the current wording really
> does put off newbies. I can definitely remember the rejection I felt
> when I've first seen a -1 for my patch  The thing is that in gerrit
> it's not so easy (especially when you see it for the first time) to
> actually notice that the text is just a standard template. One assumes
> it comes directly from the reviewer, and the lyrics used are not very
> nice

-1 actually means "I think this needs change, but if someone else approves it, 
I'm not against it"

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20140126/47937c1f/attachment.sig>


More information about the Development mailing list