[Development] SIC adding ref-qualified overloads

Knoll Lars Lars.Knoll at digia.com
Thu Jul 31 09:14:10 CEST 2014


On 31/07/14 02:13, "Thiago Macieira" <thiago.macieira at intel.com> wrote:

>On Wednesday 30 July 2014 20:14:58 Olivier Goffart wrote:
>> > Those changes are technically source-incompatible: if you take the
>>address
>> > of one of those functions, your code will stop compiling. This was
>>found
>> > in
>> > Creator:
>> > https://codereview.qt-project.org/90988
>> >
>> > The change is transparent for regular calls of those functions.
>> 
>> It is not much different than adding an overload, and we do that quite
>> often.
>
>True, but the change to one of the Qt Creator files would not have broken
>due 
>to an overload, since there was a good context for selecting the right
>function.
>
>The other file would have broken anyway due to passing the PMF to a
>template 
>function.

+1 to adding the methods. Taking the PMF is done rarely, and the benefit
outweighs the slight source incompatibility IMO.

Cheers,
Lars



More information about the Development mailing list