[Development] Qt 5.4.0 header diff

Heikkinen Jani jani.heikkinen at theqtcompany.com
Wed Nov 19 07:03:50 CET 2014

We fixed quite many tests because of that ☹. When we did the change we didn’t understood the importance of keeping header length constant…

But now we know ;)


From: development-bounces+jani.heikkinen=theqtcompany.com at qt-project.org [mailto:development-bounces+jani.heikkinen=theqtcompany.com at qt-project.org] On Behalf Of Jason McDonald
Sent: 19. marraskuuta 2014 5:56
To: Thiago Macieira
Cc: development
Subject: Re: [Development] Qt 5.4.0 header diff

On Wed, Nov 19, 2014 at 10:25 AM, Thiago Macieira <thiago.macieira at intel.com<mailto:thiago.macieira at intel.com>> wrote:
On Tuesday 18 November 2014 19:24:13 Giuseppe D'Angelo wrote:
> Erk... would it be possible to resend the diff EXCLUDING the license
> header changes? The Gui/Widgets header diffs are huge...


The old header was actually 41 lines long. I had the threshold for "this is
the header" at 40 lines.

>From now on, it's 37 lines long.

When I was looking after license headers, I kept the number of lines fixed, which often resulted in there being blank lines at the bottom of the header.

One of the problems I found if the number of lines changed was that a bunch of translation autotests broke, as the line numbers were important in those tests.  It was a lot less work to keep the length of the headers constant.

That was in the Qt 4.x days though, where breaking those tests would have caused an immediate CI failure in the monolithic repo.

Did someone fix those tests when license header length changed, or are those tests more clever about line numbers now?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20141119/a64dff77/attachment.html>

More information about the Development mailing list