[Development] Qt 5.4.0 header diff: QtCore.diff

Thiago Macieira thiago.macieira at intel.com
Wed Nov 19 08:58:47 CET 2014


On Wednesday 19 November 2014 08:52:41 Morten Johan Sørvig wrote:
> > On 19 Nov 2014, at 02:22, Thiago Macieira <thiago.macieira at intel.com>
> > wrote:
> > 
> > Impressive number of "### Qt6" comments we're adding...
> 
> Should we mandate that the pattern for doing this is
> 
> #if QT_VERSION >= QT_VERSION_CHECK(6,0,0)
> 
> and then actually writing the Qt 6 code? There are a couple of instances of
> this already (global.h, qtypeinfo.h).

I'd say it's a good idea, if it doesn't clutter the code.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list