[Development] Qt 5.4.0 header diff: QtGui.diff

[Knoll Lars]

On 19/11/14 11:59, "Knoll Lars" <Lars.Knoll at theqtcompany.com> wrote:
>>API and style mistake -- the new constructor should very likely be
>>protected (useful only from subclasses?), but the private should be
>>passed by reference (or "QOpenGLPaintDevice(0)" gives a cryptic error):
>>
>>>  class Q_GUI_EXPORT QOpenGLPaintDevice : public QPaintDevice
>>> @@ -62,6 +53,7 @@ public:
>>>      QOpenGLPaintDevice();
>>>      explicit QOpenGLPaintDevice(const QSize &size);
>>>      QOpenGLPaintDevice(int width, int height);
>>> +    QOpenGLPaintDevice(QOpenGLPaintDevicePrivate *dd);
>>>      virtual ~QOpenGLPaintDevice();
>>>
>>>      int devType() const { return QInternal::OpenGL; }
>
>Yes, this should get fixed. I’ll prepare a patch.

https://codereview.qt-project.org/#/c/100242/