[Development] "Add tests for detach on setDevicePixelRatio()" commits in qtbase

Oswald Buddenhagen oswald.buddenhagen at theqtcompany.com
Tue Apr 7 17:13:06 CEST 2015


On Tue, Apr 07, 2015 at 04:59:20PM +0200, Stephen Kelly wrote:
> Something 'funny' is going on with
> 
>  https://codereview.qt-project.org/#/c/106855/
> 
apparently, it wasn't properly "tagged" after a manual fixup.
i hacked the database now.
everybody should check whether they don't have changes in a similarly
unholy state.

obviously, gerrit should refuse to create empty cherry-picks. that's a
rather long-standing issue ...

> See qtbase commits
> 
>  * 0b6bfe8c448179ccf9272a309d6b9ddbdc055960
>  * d9437af198726e80d68ae4d95108cb08602d07f9
>  * 22b5e178e5a32988f8c23170288ef3d48df5f00d
>  * 558c9cadddacea37669c28ec2abe62c8f5726e8e
>  * 6dcbaa487d222440c2aeeb5f0ad3bc6337d52f5d
>  * 23330d498d8b9b247fede83351a9843094540743
>  * 57c399c3e65d1339cf3c273adf840801686fb4da
>  * 0b440e1498699d0fa37114453dce3f463f0752fb
>  * b0c58c2bb4cde616302f98e4c64549ae2ae028cf
> 
> at least, all of which are empty, and
> 
>  72854081b2e3831ab6619a9c2e7f4ba0a6a1d316
> 
> which is not empty. The gerrit commit is 'staged' again even now.
> 
> What's going on? Is anything being done about this already? It's
> making a messy history and it should be stopped.
> 



More information about the Development mailing list