[Development] Are SiCs through #include cleanups considered acceptable?

[Thiago Macieira]

On Thursday 09 April 2015 11:20:30 Frank Osterfeld wrote:
> > My vote obviously goes to allowing them.
> 
> I had to fix includes when building client code with 5.5 branch (coming from
> 5.4.1), so this is an actual issue right now, not just a theoretical one. I
> can do more research which headers I needed to include, if that’s a help to
> anyone.

It's probably the QStringList change.

In Qt 5.4, QStringList included QDataStream, which included QIODevice, which 
in turn included QObject.

In Qt 5.5, the offending operator>> and << were removed from qstringlist.h, so 
the #include was dropped. Anyone relying on #include <QStringList> providing 
QIODevice and QObject will see source code compilation failures.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center