[Development] Are SiCs through #include cleanups considered acceptable?

Thiago Macieira thiago.macieira at intel.com
Thu Apr 9 20:51:11 CEST 2015


On Thursday 09 April 2015 11:45:20 Thiago Macieira wrote:
> It wasn't a gratuitous change, though. It was required so I could move some 
> QStringList methods to QList<QString>. Since qlist.h needs to include
> qstringlist.h to ensure the full specialisation of
> QListSpecialMethods<QString> is present before QList<QString> is ever 
> instantiated, I had to make sure qstringlist.h didn't include qdatastream.h
> --  because qdatastream.h includes qlist.h and boom! cyclic includes.

The objective is to make Qt6 QStringList be a typedef to QList<QString>, not a 
separate class.

We've already managed that for QByteArrayList -- it's just a typedef.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list