[Development] Rotating JPEG images by default
Gunnar Sletta
gunnar at sletta.org
Thu Apr 23 12:36:05 CEST 2015
I think we should strive to not introduce regressions on purpose. Hence:
- Revert the behavioral change in 5.4 which adds rotation to JPEGs
- Have opt-in rotation in QImageReader.
- Keep TIFF rotation as it is (and change it to the Qt-wide default for Qt 6)
Anything else will cause us a lot of pain down the line.
cheers,
Gunnar
> On 23 Apr 2015, at 12:03, Allan Sandfeld Jensen <kde at carewolf.com> wrote:
>
> On Thursday 23 April 2015, Alberto Mardegan wrote:
>> On 04/23/2015 04:53 AM, Konstantin Ritt wrote:
>>> We already have a complete solution -
>>> https://codereview.qt-project.org/110685
>>
>> That looks good.
>>
>>> All we need now is to fix the behavioral regression introduced in 5.4.
>>
>> But if I understand the code correctly, the fix above gives developers
>> an option to opt *out* of the automatic rotation, so it will still
>> behave differently than Qt < 5.4, unless the developer updates his app
>> to use the new API.
>>
>> Which to me is all very good, but I think it's not what you have been
>> suggesting in this thread.
>>
> It has gone through several iterations, and this is where it is currently at.
> If there is a consensus to change the defaults the patch can easily be amended
> again.
>
> Right now I don't see a consensus though, and personally lean both ways.
>
> `Allan
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
More information about the Development
mailing list