[Development] FileRe: Move ctors for q_declare_shared types
Marc Mutz
marc.mutz at kdab.com
Tue Jul 21 21:29:52 CEST 2015
On Tuesday 21 July 2015 18:11:20 Daniel Teske wrote:
> I wonder why Marc Mutz didn't fell the need to update the mailing list on
> his changed opinion and this fix.
Read the whole mail you're replying to, and the follow-ups:
On Monday 29 June 2015 17:50:31 Thiago Macieira wrote:
> On Monday 29 June 2015 17:14:57 Marc Mutz wrote:
> > So, it doubles the number of dtor calls, and it pessimises all code
> > around it. I am not prepared to make that pessimisation for out-of-line
> > types. People who use std::move can imo be bothered to clear the
> > moved-from object after the move in those miniscule fraction of cases
> > where that actually matters. Forcing people to use swap (if, indeed,
> > they can, because swap() doesn't bind to rvalues on the rhs) for the
> > common case is bad api design.
>
> I agree with Marc here.
[...]
> > For inline types, see https://codereview.qt-project.org/115376
Nobody spoke up again, so that's what I implemented and announced in the
[ChangeLog] here: https://codereview.qt-project.org/120771
Are we going to announce every API change on the ML now?
Thanks,
Marc
--
Marc Mutz <marc.mutz at kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - The Qt Experts
More information about the Development
mailing list